Writing 503 as status code when the external service is not respondin…

…g while doing health checks
naoman · Oct 31, 2014 · c5069ab · c5069ab
1 parent d468bb2
commit c5069ab
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/main/java/com/netflix/prana/http/api/HealthCheckHandler.java b/src/main/java/com/netflix/prana/http/api/HealthCheckHandler.java
@@ -30,6 +30,7 @@ public Observable<Void> handle(HttpServerRequest<ByteBuf> serverRequest, final H
         String externalHealthCheckURL = DynamicProperty.getInstance("prana.host.healthcheck.url").getString("http://localhost:7001/healthcheck");
         serverResponse.getHeaders().add("Content-Type", "application/xml");
         if (Strings.isNullOrEmpty(externalHealthCheckURL)) {
+            serverResponse.setStatus(HttpResponseStatus.OK);
             serverResponse.writeBytes("<health>ok</health>".getBytes());
             return serverResponse.close();
         }
@@ -38,15 +39,18 @@ public Observable<Void> handle(HttpServerRequest<ByteBuf> serverRequest, final H
             @Override
             public Observable<Void> call(HttpClientResponse<ByteBuf> response) {
                 if (response.getStatus().code() == HttpResponseStatus.OK.code()) {
+                    serverResponse.setStatus(HttpResponseStatus.OK);
                     serverResponse.writeBytes("<health>ok</health>".getBytes());
                     return serverResponse.close();
                 }
+                serverResponse.setStatus(HttpResponseStatus.SERVICE_UNAVAILABLE);
                 serverResponse.writeBytes("<health>fail</health>".getBytes());
                 return serverResponse.close();
             }
         }).onErrorFlatMap(new Func1<OnErrorThrowable, Observable<Void>>() {
             @Override
             public Observable<Void> call(OnErrorThrowable onErrorThrowable) {
+                serverResponse.setStatus(HttpResponseStatus.SERVICE_UNAVAILABLE);
                 serverResponse.writeBytes("<health>fail</health>".getBytes());
                 return serverResponse.close();
             }