-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: account for timeouts during job status checks #2767
Conversation
@@ -70,6 +70,10 @@ def _is_pending(self, taskid): | |||
terminal_output='allatonce').run() | |||
return res.runtime.stdout.find(str(taskid)) > -1 | |||
except RuntimeError as e: | |||
if any(ss in str(e) for ss | |||
in ['Socket timed out', 'not available at the moment']): | |||
# do not raise error and allow recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be a good idea to add a log entry for this case.
Codecov Report
@@ Coverage Diff @@
## master #2767 +/- ##
=========================================
- Coverage 67.5% 62.8% -4.71%
=========================================
Files 340 337 -3
Lines 43238 43105 -133
Branches 5362 5343 -19
=========================================
- Hits 29187 27071 -2116
- Misses 13351 14985 +1634
- Partials 700 1049 +349
Continue to review full report at Codecov.
|
Merge master to fix tests? |
Thanks for addressing this so quickly. @dalejn is going to test and report back. |
@dalejn Any updates? |
Yes, thank you for getting to this so promptly! |
great - let us know if anything come up |
Summary
Fixes #2766 .
List of changes proposed in this PR (pull-request)
Acknowledgment
cc @agt24 - could you test out this branch and see if you still run into problems?