This repository was archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 187
Support group by in new sql parser #724
Merged
dai-chen
merged 35 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-group-by-in-new-sql-parser
Sep 8, 2020
Merged
Support group by in new sql parser #724
dai-chen
merged 35 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-group-by-in-new-sql-parser
Sep 8, 2020
+1,038
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloe-zh
approved these changes
Sep 8, 2020
penghuo
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
column
fromtable
group bycolumn
order bycolumn
LIMIT 5" is not supported #643: Group by multi fieldDescription of changes: This PR is to change the grammar in new SQL parser and integrate with core engine. The basic idea is:
Aggregation
node with aggregators, so the output aggregation of SQL is same as PPL AST builder.To make 1st item happen, the major change is adding a new domain class
QuerySpecification
and separate AST building process into 2 phases. Copy and pasting JavaDoc for your reference. Please see JavaDoc onQuerySpecification
andAstAggregationBuilder
class.Documentation: No impact from user perspective so the old doc still up-to-date.
Testing: Add comparison test for basic cases and all bug fixes above. 3 legacy IT has to be skipped and the reason is listed in
@Ignore
annotation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.