-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Software Design and User Interface of ESPnet-SE++: Speech Enhancement for Robust Speech Processing #5403
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @justusschockConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@faroit @neillu23 I completed my review and I recommend the paper for publication. I did not (yet) check the quality of writing box as I the layout of the paper (with the big figures on pages 3-7) doesn't look too good. I'd recommend to either change the formatting there or find another way to present the information. From the wording and language itself, the paper is fine though. |
@justusschock thanks for your review. Can you please add an issue to the repo so that we can track it back here? @neillu23 i agree with @justusschock that this could be improved |
@joimort We are typically aiming for reviews to be completed within about 2-4 week. So please let me know if you need any help. |
@justusschock @faroit I appreciate your review! I plan to create a pull request to make changes to the figure. Should I proceed with it immediately or should I wait for the results of the other review? |
Review checklist for @joimortConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thanks for your submission, @neillu23! The software and documentation meets all the criteria of the JOSS. Also, the accompanying paper is generally well-written. It provides a comprehensive view of the technology. However, I do have a few recommendations that could enhance readability and clarity. For instance, the section "ESPNet-SE++ Recipes for SSE and Joint-Task" commences with a screenshot of the folder structure, which can be somewhat confusing for readers. As suggested by @justusschock, it would be better to present this information in a different way. The textual content contained in the figures on pages 2-7 could be transformed into straightforward text, which would be easier to understand. For the exact structure of the folders, perhaps the authors could refer the reader to the respective README files for further clarification. Figures throughout the manuscript are not numbered, which could potentially lead to confusion. It is unclear whether this is a JOSS requirement, so the authors might want to consult the JOSS guidelines regarding this matter. Specifically, the figures on pages 7 and 9 possess two titles, adding to the ambiguity. Some other minor imperfections: In terms of the code examples provided on pages 11 and 12, it is unclear why the code is highlighted. A minor formatting issue was noticed in lines 154/155, where a link appears to be improperly formatted due to a line break. Lastly, there are a two points related to citations that need to be addressed. In line 198, the authors reference "Asteroid" but cite it with the arXiv version (published at Interspeech). Similarly, the conference name, Interspeech, is missing in line 217. These recommendations are intended to further enhance the quality of this already solid manuscript. The ESPnet-SE++ is an exciting piece of software, and this paper does a good job of presenting it to the community. |
Thanks to the review from @justusschock and @joimort ! Your feedback is truly appreciated and we'll thoughtfully integrate your suggestions into the paper. Once we have made the revisions, we will send you an updated version and let you know. Additionally, thanks to the assistance from @faroit ! |
@neillu23 can you let us know about the status of the revision? |
Hi @faroit , at present, I'm in the process of transforming pictures into text and making a new README.md file to minimize the requirement for explaining folder paths inside the document. I expect to complete these activities and make a PR by the end of this weekend. Many thanks! |
I have submitted a PR at espnet/espnet#5212 to address the feedback from the reviewers. The modifications made are as follows:
I will notify you once the PR is merged. Thank you very much! |
Hello @faroit , I wanted to let you know that the PR(espnet/espnet#5212) has been successfully merged! I apologize for the delay in completing it. |
@neillu23 thats great. Thanks for letting me know. @justusschock can you let us know about the status of your review? is there something left to do for @neillu23? |
@editorialbot commands |
Hello @justusschock, here are the things you can ask me to do:
|
@editorialbot generate pdf |
Hello @faroit , I appreciate your acceptance of the paper and the guidance you've provided! I've submitted a PR to address the issue and clean up unused references in the paper.bib. Would you be able to review it and see if it's right? Thanks again! |
@editorialbot check references |
@editorialbot generate pdf |
|
@editorialbot recommend-accept |
|
|
@editorialbot recommend-accept |
|
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4790, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Huge thanks to the editor: @faroit and reviewers: @joimort, @justusschock! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to the authors @neillu23! 🥳 🍾 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@oliviaguest, much appreciation! Immense gratitude towards @faroit, @joimort, and @justusschock for all the great help! |
Submitting author: @neillu23 (Yen-Ju Lu)
Repository: https://github.com/espnet/espnet
Branch with paper.md (empty if default branch):
Version: v.202310
Editor: @faroit
Reviewers: @joimort, @justusschock
Archive: 10.5281/zenodo.10048174
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@joimort & @justusschock, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @faroit know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @justusschock
📝 Checklist for @joimort
The text was updated successfully, but these errors were encountered: