chore: remove phf from static files

[nkysg]

Closes #9946

use empty enum as dummy Functions

[joshieDo]

thanks!

i'd say we can just remove the whole thing, struct + trait, leaving only an optional field for backwards compatibility

[nkysg]

I have implemented a dummy Functions. Some function I don't familiar with , I just keep it. PTAL @joshieDo @shekhirin . Thx.

[shekhirin]

We can also remove this

reth/crates/storage/nippy-jar/src/lib.rs

Lines 396 to 400 in 97e153a

	// Builds perfect hashing function from the values
	if let Some(phf) = self.phf.as_mut() {
	debug!(target: "nippy-jar", ?row_count, values_count = ?values.len(), "Setting keys for perfect hashing function.");
	phf.set_keys(&values)?;
	}

, so it will not require us to have set_keys implemented anymore, and we can have just an empty enum or any other dummy field even without a hashmap.

[nkysg]

remove whole struct and trait, PTAL. @joshieDo @shekhirin Thx.

[shekhirin]

almost there, also @joshieDo PTAL

[shekhirin]

Amazing, LGTM! Waiting for @joshieDo review, and we will also need to check that this doesn't break existing clients.

[mattsse]

ptal @joshieDo

[joshieDo]

looks good, just want to be sure and test it myself. either today or tomorrow 🫡

[emhane]

@joshieDo status on testing?

[joshieDo]

lgtm, pushed test_config_serialization. we can also remove the filter in a follow-up

would merge after release though

[nkysg]

lgtm, pushed test_config_serialization. we can also remove the filter in a follow-up

would merge after release though

Wonder do some follow-up .

[emhane]

lgtm, pushed test_config_serialization. we can also remove the filter in a follow-up

would merge after release though

would you open an issue pls @joshieDo ? or @nkysg if you have enough context?

[nkysg]

I think its this place.

reth/crates/static-file/types/src/filters.rs

Lines 31 to 38 in 0b6480c

	pub enum PerfectHashingFunction {
	#[strum(serialize = "fmph")]
	/// Fingerprint-Based Minimal Perfect Hash Function
	Fmph,
	#[strum(serialize = "gofmph")]
	/// Fingerprint-Based Minimal Perfect Hash Function with Group Optimization
	GoFmph,
	}

@emhane . right @joshieDo ?

[nkysg]

It seems that can merge. And I wonder do some follow-up. @shekhirin @joshieDo