chore: separate trait for conversion into state provider #10858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
joshieDo,
rkrasiuk,
rakita,
shekhirin,
mattsse and
Rjected
as code owners
mattsse
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
I believe we need this because we want to make BlockchainProvider generic over storage which is supposed to serve historicalstate.
This unblocks removal of concrete ProviderFactory usage in reth-blockchain-tree
about this, we'll remove this crate once we stabilized the new engine impl, so please don't focus to much on this.
but this trait is relevant regardless.
Comment on lines
+145
to
+146
| impl<TX: DbTx + 'static> TryIntoHistoricalStateProvider for DatabaseProvider<TX> { | ||
| fn try_into_history_at_block( |
There was a problem hiding this comment.
ah we need to consume this type here, hence this accepts self.
I believe this is special case because the blockchain-tree operates on the providerfactory directly.
joshieDo
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #10797
Extracts conversion of
DatabaseProviderintoStateProviderBoxinto separate trait. This unblocks removal of concreteProviderFactoryusage inreth-blockchain-tree