feat: make DatabaseProvider generic over chainspec
#10978
Merged
+290
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
commented
Sep 18, 2024
| @@ -462,7 +462,8 @@ where | |||
| ) -> bool { | |||
| // On Optimism, the proposers are allowed to reorg their own chain at will. | |||
| #[cfg(feature = "optimism")] | |||
| if self.blockchain.chain_spec().is_optimism() { | |||
| if reth_chainspec::EthChainSpec::chain(self.blockchain.chain_spec().as_ref()).is_optimism() | |||
There was a problem hiding this comment.
unsure what's the best way to do this. for now just changed to checks on chain id, but I guess there are cases that we don't cover by this?
There was a problem hiding this comment.
We prob should get rid of the feature flag altogether and capture this logic in the OP engine consensus impl?
joshieDo
reviewed
Sep 18, 2024
joshieDo
approved these changes
Sep 19, 2024
klkvr
force-pushed
the
klkvr/chainspec-generic
branch
from
63c01a4
to
0571be3
Compare
joshieDo
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10934
Relaxes
ProviderChainSpecbound and only restricts chainspec toEthereumHardforks