Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to retrieve topics without modifying state #80

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

jkarlin
Copy link
Collaborator

@jkarlin jkarlin commented Jul 15, 2022

As discussed in #54

@jkarlin jkarlin merged commit 7dbfe8b into main Sep 27, 2022
aarongable pushed a commit to chromium/chromium that referenced this pull request Sep 27, 2022
It'd be useful to split apart the get/set functionalities:
patcg-individual-drafts/topics#80

Also remove dead code: ../modules/browsing_topics/idls.gni

Bug: 1334682
Change-Id: I9ebb0b4bdb7c3f398b6a69ab632eecfd2af494eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696816
Reviewed-by: Joe Mason <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1051859}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
It'd be useful to split apart the get/set functionalities:
patcg-individual-drafts/topics#80

Also remove dead code: ../modules/browsing_topics/idls.gni

Bug: 1334682
Change-Id: I9ebb0b4bdb7c3f398b6a69ab632eecfd2af494eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696816
Reviewed-by: Joe Mason <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1051859}
NOKEYCHECK=True
GitOrigin-RevId: 1d60ed3f4d57627c6c47e609c554d90a2d66ee03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant