Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option for logging to co-exist with existing loggers #67

Closed
jhay317 opened this issue Aug 2, 2022 · 3 comments · Fixed by #93
Closed

Allow option for logging to co-exist with existing loggers #67

jhay317 opened this issue Aug 2, 2022 · 3 comments · Fixed by #93
Assignees
Labels
bug Minor Up to 4 hours

Comments

@jhay317
Copy link

jhay317 commented Aug 2, 2022

Currently in the init.py a reset is performed for all loggers that exist. This can cause issues when this is integrated into other applications where logging is utilized. Two options on how this can be resolved are either an addition to the configuration file to allow_other_loggers: True or to expose the logger that exists within the PeeringDB API to be added to existing loggers. This is pretty common with other libraries.

@grizz grizz added the bug label Oct 14, 2022
@grizz
Copy link
Member

grizz commented Oct 14, 2022

Good point, thanks!

@peeringdb/pc This should get a priority for release.

@grizz grizz added the Minor Up to 4 hours label Oct 14, 2022
@grizz grizz added this to the 4 Ready for Implementation milestone Oct 14, 2022
@martinhannigan
Copy link

martinhannigan commented Oct 14, 2022 via email

@leovegoda leovegoda self-assigned this Mar 18, 2024
@floatingstatic
Copy link

Just ran into this. +1 for fixing

vegu pushed a commit that referenced this issue Jul 18, 2024
@vegu vegu mentioned this issue Jul 18, 2024
@vegu vegu closed this as completed in #93 Jul 30, 2024
vegu added a commit that referenced this issue Jul 30, 2024
fixes #67
fixes #72

Co-authored-by: 20C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Minor Up to 4 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants