-
Notifications
You must be signed in to change notification settings - Fork 7.8k
ext/pdo: Fix various bugs related to PDORow #13512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you, the commits were separate and easy to read. Looks good to me as a change to this problem. However, I discovered a use case like this:
result:
The solution is to fallback from notes: If nothing is specified for |
There are cases like this.
So there may be no point in fallback... |
Maybe we should consider this as a separate issue for now. If it passes the test, I think it looks good. |
3a1762f
to
9fdeadb
Compare
9fdeadb
to
e1c5a90
Compare
@@ -2257,74 +2257,84 @@ zend_object_iterator *pdo_stmt_iter_get(zend_class_entry *ce, zval *object, int | |||
/* }}} */ | |||
|
|||
/* {{{ overloaded handlers for PDORow class (used by PDO_FETCH_LAZY) */ | |||
static zval *row_read_column_name(pdo_stmt_t *stmt, zend_string *name, zval *rv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably from the beginning, the tag one line above doesn't seem to be closed.
Merged as b4e272c |
Easier to review commits in order.