Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allanime scraping #1139

Merged
merged 6 commits into from
Jun 5, 2023
Merged

fix: allanime scraping #1139

merged 6 commits into from
Jun 5, 2023

Conversation

justchokingaround
Copy link
Collaborator

@justchokingaround justchokingaround commented Jun 4, 2023

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@justchokingaround justchokingaround linked an issue Jun 4, 2023 that may be closed by this pull request
Copy link

@Lucifer25x Lucifer25x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works just fine

@justchokingaround
Copy link
Collaborator Author

justchokingaround commented Jun 4, 2023

TODOS:

  • make quality work or remove that option
  • scrape embeds as fallback if yt-hd and yt-sd links don't work

@port19x
Copy link
Collaborator

port19x commented Jun 4, 2023

Basic functionality is working

@justchokingaround
Copy link
Collaborator Author

justchokingaround commented Jun 4, 2023

for testing fallback to embed:

ani-cli bungo stray dogs 4 -e 3

@justchokingaround
Copy link
Collaborator Author

should be gucci gang now

@justchokingaround justchokingaround changed the title fix allanime fix: allanime scraping Jun 4, 2023
@71zenith
Copy link
Collaborator

71zenith commented Jun 4, 2023

can confirm, works

@port19x port19x marked this pull request as ready for review June 4, 2023 18:54
@CaffeineB34r
Copy link

CaffeineB34r commented Jun 4, 2023

didn't work for me until i changed lines around 151 to:
PF=`which printf
provider_id=$($PF "%b" "$hexadecimal_provider_id" | sed "s/\/clock/\/clock\.json/")
printf wasn't evaluating the hex on bash i think and this was the wonky workaround

Copy link
Contributor

@nightwolf3140 nightwolf3140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it myself, but should work.

@71zenith 71zenith assigned 71zenith and unassigned 71zenith Jun 5, 2023
@71zenith 71zenith self-requested a review June 5, 2023 04:44
@port19x port19x merged commit 26b98b4 into master Jun 5, 2023
@port19x port19x deleted the allanime-fix branch June 5, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Episode not released!
6 participants