Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove un-necessary typedefs in md5module.c and sha1module.c #131418

Closed
picnixz opened this issue Mar 18, 2025 · 0 comments
Closed

Remove un-necessary typedefs in md5module.c and sha1module.c #131418

picnixz opened this issue Mar 18, 2025 · 0 comments
Assignees
@picnixz
Labels
extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@picnixz
Copy link
Member

picnixz commented Mar 18, 2025 •
edited by bedevere-app bot
Loading

We have some legacy typedefs that are no more needed as we're using HACL* and not our own implementation for MD5 and SHA-1:

#if SIZEOF_INT == 4
typedef unsigned int MD5_INT32; /* 32-bit integer */
typedef long long MD5_INT64; /* 64-bit integer */
#else
/* not defined. compilation will die. */
#endif
#if SIZEOF_INT == 4
typedef unsigned int SHA1_INT32;        /* 32-bit integer */
typedef long long SHA1_INT64;        /* 64-bit integer */
#else
/* not defined. compilation will die. */
#endif

Linked PRs
@picnixz picnixz added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Mar 18, 2025
@picnixz picnixz self-assigned this Mar 18, 2025
@bedevere-app bedevere-app bot mentioned this issue Mar 18, 2025
Merged
picnixz added a commit that referenced this issue Mar 23, 2025
@picnixz
gh-131418: remove unused legacy typedefs in {md5,sha1}module.c (#13…
a9a399f 
…1420)

- Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c`
- Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`.

Those legacy typedefs were used to detect whether the host platform could
correctly implement MD5 and SHA-1, but this is no longer needed as we now
fallback to HACL* implementations.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 23, 2025
@picnixz @miss-islington
pythongh-131418: remove unused legacy typedefs in {md5,sha1}module.c (
c08a228 
pythonGH-131420)

- Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c`
- Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`.

Those legacy typedefs were used to detect whether the host platform could
correctly implement MD5 and SHA-1, but this is no longer needed as we now
fallback to HACL* implementations.
(cherry picked from commit a9a399f)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 23, 2025
@picnixz @miss-islington
pythongh-131418: remove unused legacy typedefs in {md5,sha1}module.c (
e61dd08 
pythonGH-131420)

- Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c`
- Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`.

Those legacy typedefs were used to detect whether the host platform could
correctly implement MD5 and SHA-1, but this is no longer needed as we now
fallback to HACL* implementations.
(cherry picked from commit a9a399f)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This was referenced Mar 23, 2025
Merged
Merged
picnixz added a commit that referenced this issue Mar 23, 2025
@miss-islington @picnixz
[3.12] gh-131418: remove unused legacy typedefs in `{md5,sha1}module.…
63a4273 
…c` (GH-131420) (#131619)

gh-131418: remove unused legacy typedefs in `{md5,sha1}module.c` (GH-131420)

- Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c`
- Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`.

Those legacy typedefs were used to detect whether the host platform could
correctly implement MD5 and SHA-1, but this is no longer needed as we now
fallback to HACL* implementations.
(cherry picked from commit a9a399f)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this issue Mar 23, 2025
@miss-islington @picnixz
[3.13] gh-131418: remove unused legacy typedefs in `{md5,sha1}module.…
4af3d0e 
…c` (GH-131420) (#131620)

gh-131418: remove unused legacy typedefs in `{md5,sha1}module.c` (GH-131420)

- Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c`
- Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`.

Those legacy typedefs were used to detect whether the host platform could
correctly implement MD5 and SHA-1, but this is no longer needed as we now
fallback to HACL* implementations.
(cherry picked from commit a9a399f)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz closed this as completed Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picnixz picnixz

Labels
extension-modules C modules in the Modules dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@picnixz