-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120170: Exclude __mp_main__ in C version of whichmodule() #120171
base: main
Are you sure you want to change the base?
Conversation
The following commit authors need to sign the Contributor License Agreement: |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
With respect to the CLA, I am making this contribution on behalf of my organization, D. E. Shaw & Co., L.P. In 2018 we signed a CLA associated with the bugs.python.org username |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misc/NEWS.d/next/Library/2024-06-06-17-49-07.gh-issue-120170.DUxhmT.rst
Outdated
Show resolved
Hide resolved
The following commit authors need to sign the Contributor License Agreement: |
Importing multiprocessing adds an alias to __main__ named __mp_main__. In python#23403, the Python version of whichmodule() was fixed to exclude __mp_main__. Apply the same fix to the C version of the function.
@li-dan You'll need to sign the CLA individually as well. |
Thanks for taking a look at this, @lysnikolaou. Is there any documentation on the CLA policy? My organization is making this contribution and holds rights to the contribution, so it doesn't seem correct that I should be involved in the licensing process as an individual. |
Importing multiprocessing adds an alias to
__main__
named__mp_main__
. In #23403, the Python version of whichmodule() was fixed to exclude__mp_main__
. Apply the same fix to the C version of the function.