Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120170: Exclude __mp_main__ in C version of whichmodule() #120171

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

li-dan
Copy link

@li-dan li-dan commented Jun 6, 2024

Importing multiprocessing adds an alias to __main__ named __mp_main__. In #23403, the Python version of whichmodule() was fixed to exclude __mp_main__. Apply the same fix to the C version of the function.

Copy link

cpython-cla-bot bot commented Jun 6, 2024

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@bedevere-app
Copy link

bedevere-app bot commented Jun 6, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@li-dan
Copy link
Author

li-dan commented Jun 6, 2024

With respect to the CLA, I am making this contribution on behalf of my organization, D. E. Shaw & Co., L.P. In 2018 we signed a CLA associated with the bugs.python.org username katz.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @li-dan! I'm going to approve this, since it seems straightforward enough. However, it'd be best if someone else was to give it a quick look.

Also, should @li-dan re-sign the CLA? What's the process here? cc @ambv

Copy link

cpython-cla-bot bot commented Jan 29, 2025

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

Importing multiprocessing adds an alias to __main__ named __mp_main__.
In python#23403, the Python version of whichmodule() was fixed to exclude
__mp_main__. Apply the same fix to the C version of the function.
@lysnikolaou
Copy link
Member

@li-dan You'll need to sign the CLA individually as well.

@li-dan
Copy link
Author

li-dan commented Mar 19, 2025

Thanks for taking a look at this, @lysnikolaou.

Is there any documentation on the CLA policy? My organization is making this contribution and holds rights to the contribution, so it doesn't seem correct that I should be involved in the licensing process as an individual.

@lysnikolaou
Copy link
Member

I'm not sure what the correct thing to do here is. @ambv You probably know best. Could you please address @li-dan's concerns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants