-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-121529: Document from_ parameter in _mboxMMDF methods #121530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from_ should be italic, as *from_*
in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! "unix" is a proper noun, it should be capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I think 'From '
should use double quotes, as that's what's used in the docs already (see here, for example)
Sorry for not catching the other two changes in my initial review, that's my fault. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll leave nitpicking the rest to someone else.
@picnixz Here's an easy review in the backlog if you want to take a look. (This predates both of our triage memberships 😆.) |
I was just writing the commit message :') |
Actually, I've just observed that the documentation is not updating the paragraph for the Line 947 in 1e4a434
mailbox.MMDF also inherits the same interface)
The commit title will be
The commit message will be
|
I'll review it tomorrow and merge it if it's fine. Thanks for updating those docs btw |
…hods (pythonGH-121530) (cherry picked from commit 557d2d2) Co-authored-by: Sebb <sebbASF@users.noreply.github.com>
GH-131622 is a backport of this pull request to the 3.12 branch. |
…hods (pythonGH-121530) (cherry picked from commit 557d2d2) Co-authored-by: Sebb <sebbASF@users.noreply.github.com>
GH-131623 is a backport of this pull request to the 3.13 branch. |
📚 Documentation preview 📚: https://cpython-previews--121530.org.readthedocs.build/