gh-129900: Fix SystemExit return codes when the REPL is started from the command line
#129901
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ZeroIntensity
commented
Feb 9, 2025
•
ZeroIntensity
commented
- Issue: Exit code in case of an error is always 1 since Python 3.13 #129900
chrisbra
added a commit
to vim/vim
that referenced
this pull request
Feb 9, 2025
…ndows Problem: tests: fix expected return code for python 3.13 on Windows Solution: Check for return code 1 or 123 on Windows There is a regression with python 3.13 on Windows, that it no longer prints the requested error code, but instead exits with return code 1, which breaks the test-suite. So let's check for either exit code 1 or 123 in tests Test_terminal_duplicate_eof_arg() and Test_terminal_eof_arg() This will probably be fixed on the Python side, see the pull request python/cpython#129901 but in the meantime, let's allow both error codes. related: #16599 related: python/cpython#129900 Signed-off-by: Christian Brabandt <cb@256bit.org>
vstinner
approved these changes
Mar 25, 2025
Modules/main.c
Outdated
| @@ -563,7 +563,7 @@ pymain_run_stdin(PyConfig *config) | |||
| return (run != 0); | |||
| } | |||
| int run = pymain_run_module(L"_pyrepl", 0); | |||
| return (run != 0); | |||
| return run; | |||
There was a problem hiding this comment.
You can just write return pymain_run_module(L"_pyrepl", 0);.
|
The CIFuzz job is acting up, I've rebased to see if that fixes it. |
|
Thanks @ZeroIntensity for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 25, 2025
…ed from the command line (pythonGH-129901) (cherry picked from commit 90b82f2) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-131734 is a backport of this pull request to the 3.13 branch. |
|
Merged, thanks for the fix. The backport will be merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.