-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-130524 Create WinGetpassTest class for improved coverage #130529
base: main
Are you sure you want to change the base?
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
8e5ff2b
to
850a357
Compare
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
the macOS tests are failing which is odd given the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
@floor-licker ./python Lib/test/test_getpass.py and also please don't forget to add news entry file (using blurb) at least when ci requires it, they should be passed. you can read the errors in the github actions logs, everything is described there (you just don't define the objects you use) |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Misc/NEWS.d/next/Tests/2025-02-25-02-37-57.gh-issue-130524.cERebk.rst
Outdated
Show resolved
Hide resolved
12e3303
to
b2e44fc
Compare
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
BTW, please do not force-push; it makes reviewing harder. Moreover, all commits are squashed upon merge anyway, so there's no need for the PR/branch to be cluttered with amendment commits. See also the devguide. |
@donBarbos my apologies for the mess, just lost access to my windows machine so I've been trying to sort this out on macOS. I'll create a partition and come up with a fix. Thanks for the info, I'll give it a read. |
It seems that the CI is failing because the test hangs. I'm converting it to a draft until the CI is green again. |
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: donBarbos <donbarbos@proton.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
The tests still don't seem to work. Are you willing to continue working on this @floor-licker or should someone else take over (I can't because I don't have a Windows for that; maybe @donBarbos could as it's blocking #130496). |
Improved Getpass coverage for Windows
I followed the same pattern as the Unix tests, the new class tests the core functionality of
win_getpass
usingmsvcrt.getch
for input, verifies proper handling of special characters including keyboard interrupt, ensures stream flushing works correctly, and a test forfallback_getpass()
to test themscvrt
fallback mechanism when the primary method fails.getpass
#130524