Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-130673: Gracefully handle section in jit build #130906

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

rennsax
Copy link
Contributor

@rennsax rennsax commented Mar 6, 2025

Copy link

cpython-cla-bot bot commented Mar 6, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Mar 6, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Mar 6, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@rennsax rennsax marked this pull request as ready for review March 6, 2025 05:03
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Did you confirm that this fixes your build?

Per the bot, please add a blurb entry to the Build section. No need to force-push either; it just makes reviewing more difficult, and everything is squashed at the end anyway. You might want to look at the devguide for some advice on PRs.

@rennsax
Copy link
Contributor Author

rennsax commented Mar 6, 2025

Thanks for doing this! Did you confirm that this fixes your build?

Yeah, I've tested on 3.13.2 and main branch. It just works.

Per the bot, please add a blurb entry to the Build section.

Thanks for your remind! This is my first time opening PR for CPython and thanks for your review!

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Mind adding a comment explaining why we're returning early here?

@rennsax
Copy link
Contributor Author

rennsax commented Mar 8, 2025

Does this CI failure matter?

@brandtbucher brandtbucher merged commit a26a301 into python:main Mar 25, 2025
63 checks passed
@miss-islington-app
Copy link

Thanks @rennsax for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2025
…honGH-130906)

(cherry picked from commit a26a301f8b09c1825b288fc8649f8174576361f4)

Co-authored-by: Bojun Ren <bj.ren.coding@outlook.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 25, 2025

GH-131749 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT build crashes on x86_64-linux with LLVM 18
4 participants