-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-130673: Gracefully handle section in jit build #130906
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Did you confirm that this fixes your build?
Per the bot, please add a blurb entry to the Build
section. No need to force-push either; it just makes reviewing more difficult, and everything is squashed at the end anyway. You might want to look at the devguide for some advice on PRs.
Yeah, I've tested on 3.13.2 and main branch. It just works.
Thanks for your remind! This is my first time opening PR for CPython and thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks. Mind adding a comment explaining why we're returning early here?
Does this CI failure matter? |
Thanks @rennsax for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…honGH-130906) (cherry picked from commit a26a301f8b09c1825b288fc8649f8174576361f4) Co-authored-by: Bojun Ren <bj.ren.coding@outlook.com>
GH-131749 is a backport of this pull request to the 3.13 branch. |
Fix #130673