GH-131358: Add encoding alias cseuckr for euc_kr #131370
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
srinivasreddy
commented
Mar 17, 2025
•
srinivasreddy
commented
- Issue: Encoding alias csEUCKR not supported #131358
srinivasreddy
changed the title
picnixz
reviewed
Mar 17, 2025
Misc/NEWS.d/next/Library/2025-03-17-21-35-53.gh-issue-131358.YVZ6yo.rst
Outdated
Show resolved
Hide resolved
…VZ6yo.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
corona10
reviewed
Mar 18, 2025
|
FTR, it's documented in https://developer.mozilla.org/en-US/docs/Web/API/Encoding_API/Encodings so I guess it can exist in the wild? |
|
I believe that it's a very old encoding (except the banking system), and even if they use |
|
I am not sure it's worth adding it because we don't support all aliases that are listed on the JDK or Mozilla page. @methane Do you have any ideas with this issue? |
|
For example, there is also |
|
alias is imported by all Python programs. So I don't like adding everything in alias. But in case of csEUCKR, it is used in real world.
I'm OK to adding it. |
methane
approved these changes
Mar 19, 2025
corona10
approved these changes
Mar 19, 2025
colesbury
pushed a commit
to colesbury/cpython
that referenced
this pull request
Mar 20, 2025
* Add encoding alias cseuckr for euc_kr * Update Misc/NEWS.d/next/Library/2025-03-17-21-35-53.gh-issue-131358.YVZ6yo.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> --------- Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.