Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-125866: Deprecate nturl2path module #131432

Merged
merged 8 commits into from
Mar 19, 2025
Merged

GH-125866: Deprecate nturl2path module #131432

merged 8 commits into from
Mar 19, 2025
+180 −35

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Mar 18, 2025 •
edited
Loading

Deprecate the nturl2path module. Its functionality is merged into urllib.request.

Add tests.test_nturl2path to exercise nturl2path, as it's no longer covered by test_urllib.

@barneygale
pythonGH-125866: Add tests for nturl2path module
033baf5 
Add `tests.test_nturl2path` to exercise `nturl2path`.

`nturl2path` is currently used by `urllib` and tested by `test_urllib`, but
that will change when we deprecate `nturl2path` and add support for Windows
paths/URLs in `urllib` itself.
@barneygale barneygale added tests Tests in the Lib/test dir OS-windows skip news labels Mar 18, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 18, 2025
Open
@barneygale barneygale changed the title GH-125866: Add tests for nturl2path module GH-125866: Deprecate nturl2path module Mar 19, 2025
@barneygale barneygale removed the tests Tests in the Lib/test dir label Mar 19, 2025
@barneygale barneygale marked this pull request as ready for review March 19, 2025 00:43
serhiy-storchaka
serhiy-storchaka approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Wulian233
Copy link
Contributor

I split out the nturl2path tests 8 months ago. This PR does more and includes it. Maybe I'll close my PR after this merge?

#122372

zooba
zooba reviewed Mar 19, 2025
View reviewed changes
@barneygale
Copy link
Contributor Author

I split out the nturl2path tests 8 months ago. This PR does more and includes it. Maybe I'll close my PR after this merge?

#122372

Thanks for the info - sorry I didn't spot your PR before. It looks like we arrived at a similar place.

@barneygale barneygale enabled auto-merge (squash) March 19, 2025 19:12
@barneygale barneygale merged commit 8abfaba into python:main Mar 19, 2025
39 checks passed
This was referenced Mar 19, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@barneygale @Wulian233 @zooba @serhiy-storchaka