Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-131670: Fix crash in anext() when __anext__ is sync and raises #131682

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 24, 2025

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion otherwise LGTM.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@sobolevn sobolevn added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Mar 24, 2025
@sobolevn
Copy link
Member Author

This crash happens down to 3.11 :(

@sobolevn sobolevn enabled auto-merge (squash) March 24, 2025 18:37
@sobolevn sobolevn merged commit 929afd1 into python:main Mar 24, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2025
…raises (pythonGH-131682)

(cherry picked from commit 929afd1)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 24, 2025

GH-131686 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 24, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2025
…raises (pythonGH-131682)

(cherry picked from commit 929afd1)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 24, 2025

GH-131687 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 24, 2025
sobolevn added a commit that referenced this pull request Mar 24, 2025
… raises (GH-131682) (#131687)

gh-131670: Fix crash in `anext()` when `__anext__` is sync and raises (GH-131682)
(cherry picked from commit 929afd1)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
sobolevn added a commit that referenced this pull request Mar 24, 2025
… raises (GH-131682) (#131686)

gh-131670: Fix crash in `anext()` when `__anext__` is sync and raises (GH-131682)
(cherry picked from commit 929afd1)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants