Fix color leakage #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only colorizing output that indicates test result status. This includes "ok", "PASS", etc. The fix prevents that coloration from remaining set and colorizing error and logging output that doesn't directly indicate whether a test passed or failed. For example, a line like "some/package/file.go:20:10: something went wrong" won't be colorized.
This reverts commit f35ce18. Omitting or including the vendor directory is up to the maintainer and outside the scope of this change
|
I've reverted the out-of-scope removal of the vendor directory and updated this with the latest upstream master. This should be ready for a final review / merge. |
Closed
This was bundled into the color leakage fix commit, but it is out of scope for these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output that isn't prepended with a status like "ok" or "FAIL" is being colorized.
For example, if the line "ok github.com/some/package" is followed by "some/package/file.go:20:10 there was an error", the second line will be colored green. This is confusing, because the second line is likely error output belonging to the subsequent test.
This fix will reset the color palette after colorizing status-related output.
This PR is a revision of a previous PR.