Implement Night Owl theme for syntax highlighting #1125
+33
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for reactjs ready! Built with commit b026975 |
|
Hi @gaearon is there still interest in this? Here's a preview, made some changes so the vibrancy difference isn't an issue anymore: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned here: #1093 (comment)
Link to Night Owl theme (slightly modified)
It also uses the tomato color for component/class tags once PrismJS/prism#1519 goes through.
The global
theme.jscolors somewhat conflict visually now, however. The Night Owl theme uses more saturated colors (especially the dark blue background), so it seems like the theme colors need to change to fit the increased vibrancy.