Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add useEffectEvent to the sidebar menu #6635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MatanBobi
Copy link
Contributor

@MatanBobi MatanBobi commented Feb 16, 2024

This PR adds the experimental_useEffectEvent page to the API reference menu.
As this hook is being referenced in the learn section but the page wasn't visible in the menu (while other new experimental hooks are in the menu), it seemed like this hook is not planned anymore. Adding it to the menu states that this API is something the React core team aims to ship.

image

I'd love to expand the content in another PR if you all believe this will help.

Thanks for all your hard work! :)

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 16, 2024 11:35am

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[[...markdownPath]] 81.45 KB (🟡 +13 B) 185.31 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@eps1lon eps1lon requested a review from rickhanlonii February 18, 2024 19:03
@rickhanlonii
Copy link
Member

Hey, sorry for the confusion, I didn't realize this was the page you were suggesting. We may be making some changes to this API before it lands so let's wait to add this page until it's closer to final.

@MatanBobi
Copy link
Contributor Author

Oh, no worries, thanks @rickhanlonii!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants