fix: correct path handling for file name extraction in rss.js
#7005
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: correct path handling for file name extraction in
rss.js
Hello😊 Thank you for your attention to this matter :)
1. Description
This PR addresses an issue with path handling in
rss.js
. This makes it impossible for Windows users to run dev server throughyarn dev
.The problem was identified when the
generateRssFeed
method failed to exclude theindex.md
file correctly, causing errors due to missing metadata fields required for RSS feeds.2. Solution
The solution is to use the
path.basename
method, which correctly extracts the file name from a path regardless of the operating system's path separator(/
or\
). Here are the key changes made:This ensures that the file name is accurately extracted, and the
index.md
file is correctly excluded from the RSS feed generation process.3. Conclusion
This PR fixes the path handling issues, ensuring compatibility across different operating systems(Windows or Linux/Mac) by using the appropriate methods for file name extraction and path manipulation.