Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global mutation avoided addressing issue #7497 #7630

Closed
wants to merge 1 commit into from

Conversation

TheCaptain1810
Copy link
Contributor

The issue #7497 is fixed but one example of global mutation of nextId is kept as is to make a point about mutation. If it also needs to be changed provide feedback.

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 10:48am
react-dev ✅ Ready (Inspect) Visit Preview Feb 18, 2025 10:48am

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@gaearon
Copy link
Member

gaearon commented Feb 18, 2025

Thanks but this is unnecessary. The original code is correct.

#7497 (comment)

@gaearon gaearon closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants