Development: allow to use --ngrok when starting Docker #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Together with readthedocs/readthedocs.org#9353 this commit will allow developers to run NGROK with the local instance just by passing another argument. ``` inv docker.up --ngrok readthedocs.ngrok.io ```
benjaoming
approved these changes
Jun 21, 2022
| @@ -23,7 +23,7 @@ services: | |||
| - proxito | |||
| - storage | |||
| volumes: | |||
| - ${PWD}/dockerfiles/nginx:/etc/nginx/conf.d | |||
| - ${PWD}/dockerfiles/nginx:/etc/nginx/templates | |||
There was a problem hiding this comment.
Really good idea to start using envsubst 👍 This is a good step towards convergence between development docker images and production. Ideally, the same Docker images can be used in multiple deployments and after having isolated variables as environment variables, we can reduce reliance on volumes and build configurations straight into the images.
There was a problem hiding this comment.
Note that this is incompatible with current readthedocs-corporate setup.
There was a problem hiding this comment.
Note that this is incompatible with current readthedocs-corporate setup.
Yes, we will need to do some work there to support ngrok as well.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with readthedocs/readthedocs.org#9353 this
commit will allow developers to run NGROK with the local instance just by
passing another argument.