Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow optional configuration values #5798

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Can be avoided now due to 0d04196.

@SwiftLintBot
Copy link

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
📖 Linting Aerial with this PR took 0.92s vs 0.92s on main (0% slower)
📖 Linting Alamofire with this PR took 1.27s vs 1.27s on main (0% slower)
📖 Linting Brave with this PR took 7.43s vs 7.45s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 4.99s vs 5.01s on main (0% faster)
📖 Linting Firefox with this PR took 10.98s vs 11.0s on main (0% faster)
📖 Linting Kickstarter with this PR took 10.03s vs 10.04s on main (0% faster)
📖 Linting Moya with this PR took 0.52s vs 0.53s on main (1% faster)
📖 Linting NetNewsWire with this PR took 2.55s vs 2.56s on main (0% faster)
📖 Linting Nimble with this PR took 0.77s vs 0.77s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.42s vs 8.71s on main (3% faster)
📖 Linting Quick with this PR took 0.44s vs 0.45s on main (2% faster)
📖 Linting Realm with this PR took 4.67s vs 4.7s on main (0% faster)
📖 Linting Sourcery with this PR took 2.34s vs 2.35s on main (0% faster)
📖 Linting Swift with this PR took 4.6s vs 4.57s on main (0% slower)
📖 Linting VLC with this PR took 1.25s vs 1.25s on main (0% slower)
📖 Linting Wire with this PR took 18.19s vs 18.11s on main (0% slower)
📖 Linting WordPress with this PR took 11.87s vs 11.76s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Disallow optional configuration values.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit e9386ae into realm:main Sep 16, 2024
13 checks passed
@SimplyDanny SimplyDanny deleted the disallow-optional-values branch September 16, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants