N36: CyberGate #1100
Merged
N36: CyberGate #1100
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17cupsofcoffee
requested changes
Jul 30, 2022
There was a problem hiding this comment.
The general content of this post looks okay, but there's a lot of issues;
- You've created a new file, rather than adding to the existing one.
- The links are not formatted correctly (if you look at the preview they're all showing up with extra markup.
- There's quite a few formatting issues (extra new lines in the list, placeholder brackets left in the initial description, etc)
Could you please update this PR/resubmit to resolve these issues and move your content to the right file?
|
is everything good now? @17cupsofcoffee |
ozkriff
approved these changes
Aug 2, 2022
|
I've rephrased a few things. @cybersoulK are you ok with my changes? |
17cupsofcoffee
approved these changes
Aug 2, 2022
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1098