Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N36: lyon 1.0 #1101

Merged
merged 3 commits into from
Aug 6, 2022
Merged

N36: lyon 1.0 #1101

merged 3 commits into from
Aug 6, 2022
+22 −0

Conversation

nical
Copy link
Contributor

@nical nical commented Jul 29, 2022

Part of #1098

Here is a section about the lyon 1.0.0 release.

17cupsofcoffee
17cupsofcoffee reviewed Jul 30, 2022
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, just a few formatting tweaks.

Could you also add the image to the repo, rather than using an external link? We prefer to self-host the images in case links go stale in the future.

@nical
Copy link
Contributor Author

nical commented Jul 30, 2022

Sure, here is a new version with the formatting tweaks and the image.

17cupsofcoffee
17cupsofcoffee approved these changes Jul 30, 2022
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ty!

@ozkriff ozkriff changed the title Add a section about lyon 1.0. N36: lyon 1.0 Aug 2, 2022
@ozkriff ozkriff merged commit 590a957 into rust-gamedev:source Aug 6, 2022
@ozkriff
Copy link
Member

ozkriff commented Aug 6, 2022

Merged, thanks for the PR and congrats on 1.0 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff

@17cupsofcoffee 17cupsofcoffee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nical @ozkriff @17cupsofcoffee