Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N36: Agma #1118

Merged
merged 9 commits into from
Aug 9, 2022
Merged

N36: Agma #1118

merged 9 commits into from
Aug 9, 2022

Conversation

TuckerBMorgan
Copy link
Contributor

Part of #1098

@TuckerBMorgan TuckerBMorgan mentioned this pull request Aug 2, 2022
Closed
72 tasks
AngelOnFira
AngelOnFira requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gif is quite large, can you reduce it to <2.5MB? Otherwise lgtm :)

@ozkriff ozkriff changed the title Agma section N36: Agma Aug 8, 2022
@TuckerBMorgan
Copy link
Contributor Author

ok updated!

@AngelOnFira
Copy link
Member

The file is still showing as 5MB, are you sure you updated it properly?

ozkriff
ozkriff approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 seems like something went wrong with image optimization so I optimized it myself - hope it's ok

@ozkriff ozkriff merged commit 37ebd79 into rust-gamedev:source Aug 9, 2022
@ozkriff
Copy link
Member

ozkriff commented Aug 9, 2022

Thanks for the PR!

@TuckerBMorgan
Copy link
Contributor Author

Yeah that is fine, sorry for the extra work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngelOnFira AngelOnFira

@ozkriff ozkriff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TuckerBMorgan @AngelOnFira @ozkriff