Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N36: Release #1131

Merged
merged 6 commits into from
Aug 11, 2022
Merged

N36: Release #1131

merged 6 commits into from
Aug 11, 2022

Conversation

ozkriff
Copy link
Member

@ozkriff ozkriff commented Aug 11, 2022

Preview (ca894c3): https://rust-gamedev-preview.netlify.app/news/036

Everyone is invited to review!

Hope to merge this in a few hours if there're no objections.

Part of #1098

Copy link
Contributor

@64kramsystem 64kramsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I've noticed that the "Storm Engine" link (https://rust-gamedev-preview.netlify.app/news/036/github.com/mooman219/Storm) is a 404, but I don't know if this is significant or can be ignored.

Copy link
Contributor

@64kramsystem 64kramsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RobDavenport
Copy link
Contributor

Looks like a few of Gamercade's links are broken as well, they're linking to https://rust-gamedev-preview.netlify.app/news/036/Gamercade-Console etc etc

@AngelOnFira
Copy link
Member

Spelling + Grammar fixes in ozkriff#5

@AngelOnFira
Copy link
Member

These images are the same, is this intended?

image

Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few recommendations, but I'll take another look once a new render is up 💯

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments:

  • There's another broken link in the Agma section.
  • NES Bundler's section is slightly weirdly phrased, maybe amend to NES Bundler is a NES ROM packaging tool by..?

Any other issues I spotted have already been flagged up :)

Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) 🚀

@ozkriff ozkriff merged commit f4d1f44 into rust-gamedev:source Aug 11, 2022
@ozkriff ozkriff deleted the n36-release branch August 11, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants