Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable memset tests on powerpc64(le) #792

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

Gelbpunkt
Copy link
Contributor

@Gelbpunkt Gelbpunkt commented Mar 17, 2025

Originally disabled in #481, these tests pass fine for me on powerpc64le-unknown-linux-gnu with LLVM 20.1 and rustc 1.87.0-nightly (4d30011f6 2025-03-15).

Fixes: rust-lang/rust#99853

cc @RalfJung @Amanieu @apiraino

Full test run (successful): https://gist.github.com/Gelbpunkt/b178b3838b32154e877799e2b6395546

@RalfJung
Copy link
Member

See rust-lang/rust#99853

This should probably say "Fixes:" ?

…bug"

This reverts commit 265fdac.

Fixes: rust-lang/rust#99853

Signed-off-by: Jens Reidel <adrian@travitia.xyz>
@Gelbpunkt
Copy link
Contributor Author

See rust-lang/rust#99853

This should probably say "Fixes:" ?

You're right, added that.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@tgross35 tgross35 merged commit 98aab13 into rust-lang:master Mar 17, 2025
26 checks passed
@Gelbpunkt Gelbpunkt deleted the memset-ppc branch March 17, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiler-builtins CI fails on powerpc64
3 participants