rust.debug-assertions = true should be incompatible with rust.download-rustc = true | 'if-unchanged' atm
#133132
Assignees
Labels
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
jieyouxu
added
C-bug
rustbot
added
the
needs-triage
jieyouxu
removed
the
needs-triage
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Nov 24, 2024
…-for-tools, r=clubby789
Use `download-rustc=false` global default, `if-unchanged` for tools and library profiles, and make `rust.debug-assertions=true` inhibit downloading CI rustc
- Use `download-rustc = false` as global default.
- Use `download-rustc = 'if-unchanged'` for tools and library profiles.
- Make `rust.debug-assertions = true` inhibit downloading CI rustc because alt rustc builds do not yet have rustc debug assertions enabled.
Fixes rust-lang#133132.
cc discussions: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Bootstrap.20breakage
compiler contributors poll: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60download-rustc.20.3D.20'if-unchanged'.60.20for.20.60compiler.60.20profile.3F/near/481877253
library contributors poll: https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/.60download-rustc.20.3D.20.22if-unchanged.22.60.20default.20for.20libs.20profile.3F/near/482607011
cc https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/When.20is.20rustc.20built.20with.20debug.20assertions.3F
cc `@MarcoIeni` since you're working on improving CI job times, sorry, this will definitely regress some CI job times because we're probably lying to ourselves that CI rustc had debug assertions for some time 😅
cc `@onur-ozkan` for FYI, but since you're on vacation (sorry for the ping),
r? `@Kobzol` (I *think* you have a bit more context than other bootstrap reviewers?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before Enable debug assertions on alt builds #131077 lands, the alt rustc builds do not have rustc debug assertions enabled. However, currently
rust.download-rustc = true | "if-unchanged"incorrectly assumes that the alt rustc has rustc debug assertions enabled (it does have llvm debug assertions enabled but not rustc debug assertions). This was the reason why #132789 was failing.See the investigation and #133131 for details.
The text was updated successfully, but these errors were encountered: