Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand: Do not report cfg_attr traces on macros as unused attributes #138794

Merged
merged 1 commit into from
Mar 22, 2025
Merged

expand: Do not report cfg_attr traces on macros as unused attributes #138794

merged 1 commit into from
Mar 22, 2025
+15 −8

Conversation

petrochenkov
Copy link
Contributor

Fixes #138779

@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2025

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 21, 2025
@petrochenkov petrochenkov mentioned this pull request Mar 21, 2025
Closed
@tamird tamird mentioned this pull request Mar 21, 2025
Draft
jieyouxu
jieyouxu approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 22, 2025

📌 Commit 0ac2801 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned Nadrieril Mar 22, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 22, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
@bors
Auto merge of rust-lang#138831 - matthiaskrgr:rollup-3t0dqiz, r=matth…
b48576b 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#138609 (Add stack overflow handler for cygwin)
 - rust-lang#138639 (Clean UI tests 2 of n)
 - rust-lang#138773 (catch_unwind intrinsic: document return value)
 - rust-lang#138782 (test(ui): add tuple-struct-where-clause-suggestion ui test for rust-lang#91520)
 - rust-lang#138794 (expand: Do not report `cfg_attr` traces on macros as unused attributes)
 - rust-lang#138801 (triagebot: add autolabel rules for D-* and L-*)
 - rust-lang#138804 (Allow inlining for `Atomic*::from_ptr`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 66c3566 into rust-lang:master Mar 22, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 22, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
@rust-timer
Unrolled build for rust-lang#138794
03ca51c 
Rollup merge of rust-lang#138794 - petrochenkov:cfgtracefix, r=jieyouxu

expand: Do not report `cfg_attr` traces on macros as unused attributes

Fixes rust-lang#138779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

unused_attributes: false positive since nightly-2025-03-21 "unused attribute <cfg_attr>"
5 participants
@petrochenkov @rustbot @jieyouxu @bors @Nadrieril