Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve iface error message when types differ in boxity #2273

Closed
catamorphism opened this issue Apr 24, 2012 · 4 comments
Closed

Improve iface error message when types differ in boxity #2273

catamorphism opened this issue Apr 24, 2012 · 4 comments
Labels
A-type-system Area: Type system C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@catamorphism
Copy link
Contributor

I just got the error failed to find an implementation of interface middle::typeck::ast_conv for middle::typeck::crate_ctxt. It took me a second to figure out that my mistake was leaving off the @ on crate_ctxt. It would be nice if, in this case, the typechecker gave a hint like "did you mean @crate_ctxt?", in the case where there is an implementation of ast_conv for @crate_ctxt.

@pcwalton
Copy link
Contributor

How does this interact with issue #2212?

@catamorphism
Copy link
Contributor Author

I think it's basically independent from #2212 ? Regardless of what behavior gets decided on for #2212, I'd think it should still be possible for the typechecker to give hints in some obvious cases (obviously it won't be perfect).

@catamorphism
Copy link
Contributor Author

Hmm, I don't know what I was thinking. This seems like no longer an issue with #2212 being implemented. I can't think of a case where it does come up now. Closing.

@brson
Copy link
Contributor

brson commented Nov 9, 2012

I like the term 'boxity'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-type-system Area: Type system C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

3 participants