Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustbuild] Support exclude in config.toml, not just as a flag #35678

Closed
nagisa opened this issue Aug 15, 2016 · 10 comments · Fixed by #137147 · May be fixed by #135538
Closed

[rustbuild] Support exclude in config.toml, not just as a flag #35678

nagisa opened this issue Aug 15, 2016 · 10 comments · Fixed by #137147 · May be fixed by #135538
Assignees
@Aditya-PS-05
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@nagisa
Copy link
Member

nagisa commented Aug 15, 2016 •
edited by rustbot
Loading

debuginfo-gdb tests fail on my system due to gdb not existing/gdb being misconfigured/gdb being not actually gdb/gdb being too new/gdb being too old/gdb outputting stuff to stderr/etc. There should be a way to disable selected collections of tests altogether in rustbuild.

I tried setting debuginfo-tests to false, but it only appears to tweak whether -g gets passed to the tests by default.
@alexcrichton alexcrichton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 15, 2016
@Mark-Simulacrum
Copy link
Member

So I think this is about making ./x.py test not run certain tests. Is that the correct interpretation, @nagisa? Or did you want something else?

@nagisa
Copy link
Member Author

nagisa commented May 11, 2017

Certain groups of tests, as is stated in the original issue description.

@Mark-Simulacrum Mark-Simulacrum added C-enhancement Category: An issue proposing an enhancement or a PR with one. C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jul 25, 2017
@Mark-Simulacrum Mark-Simulacrum added this to the impl period milestone Sep 15, 2017
@aturon aturon removed this from the impl period milestone Sep 15, 2017
@davidak davidak mentioned this issue Apr 11, 2018
Closed
@Mark-Simulacrum
Copy link
Member

--exclude src/test/debuginfo would work today, though there's no way to put this in e.g. config.toml -- maybe it makes sense to add an exclude field to that?

@jyn514
Copy link
Member

jyn514 commented Jun 27, 2022

@nagisa is this still something you'd find useful? is --exclude enough, or would you use exclude in config.toml if we added support for that?

@nagisa
Copy link
Member Author

nagisa commented Jun 27, 2022

exclude in config.toml would be stellar, but I can imagine myself living with just a flag (which I can write a wrapper script over for example)

@jyn514 jyn514 changed the title [rustbuild] a way to ignore a particular kind of test [rustbuild] Support exclude in config.toml, not just as a flag Feb 3, 2023
@jyn514 jyn514 mentioned this issue Aug 5, 2024
Closed
@jieyouxu jieyouxu added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Oct 13, 2024
@Aditya-PS-05

This comment has been minimized.

Sign in to view
@oli-obk

This comment has been minimized.

Sign in to view
@Ganji00

This comment has been minimized.

Sign in to view
@workingjubilee workingjubilee mentioned this issue Jan 12, 2025
Closed
@Aditya-PS-05
Copy link
Contributor

@rustbot claim

@Aditya-PS-05 Aditya-PS-05 mentioned this issue Jan 15, 2025
Open
@Shourya742
Copy link
Contributor

Hello, @Aditya-PS-05! Are you still working on this issue?

@Shourya742 Shourya742 mentioned this issue Feb 16, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…
08109d3 
…ude-in-config.toml, r=onur-ozkan

Add exclude to config.toml

Closes: rust-lang#35678

r? ``@onur-ozkan``
tgross35 added a commit to tgross35/rust that referenced this issue Mar 2, 2025
@tgross35
Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…
f616b76 
…ude-in-config.toml, r=onur-ozkan

Add exclude to config.toml

Closes: rust-lang#35678

r? ```@onur-ozkan```
jhpratt added a commit to jhpratt/rust that referenced this issue Mar 4, 2025
@jhpratt
Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…
6299dc6 
…ude-in-config.toml, r=onur-ozkan

Add exclude to config.toml

Closes: rust-lang#35678

r? ````@onur-ozkan````
tgross35 added a commit to tgross35/rust that referenced this issue Mar 4, 2025
@tgross35
Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…
b74c6d3 
…ude-in-config.toml, r=onur-ozkan

Add exclude to config.toml

Closes: rust-lang#35678

r? `````@onur-ozkan`````
jieyouxu added a commit to jieyouxu/rust that referenced this issue Mar 9, 2025
@jieyouxu
Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…
94a477a 
…ude-in-config.toml, r=onur-ozkan

Add exclude to config.toml

Closes: rust-lang#35678

r? `@onur-ozkan`
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 10, 2025
@bors
Auto merge of rust-lang#137147 - Shourya742:2025-02-16-support-exclud…
a55c616 
…e-in-config.toml, r=<try>

Add exclude to config.toml

Closes: rust-lang#35678

r? `@onur-ozkan`

try-job: x86_64-msvc-2
@bors bors closed this as completed in b8c51f4 Mar 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 16, 2025
@rust-timer
Unrolled build for rust-lang#137147
3bd10eb 
Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-exclude-in-config.toml, r=onur-ozkan

Add exclude to config.toml

Closes: rust-lang#35678

r? `@onur-ozkan`

try-job: x86_64-msvc-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aditya-PS-05 Aditya-PS-05

Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
10 participants
@alexcrichton @oli-obk @nagisa @aturon @Mark-Simulacrum @jyn514 @jieyouxu @Ganji00 @Shourya742 @Aditya-PS-05