Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate extern-flag-pathless, silly-file-names, metadata-dep-info, cdylib-fewer-symbols and symbols-include-type-name run-make tests to rmake #127006

Merged
merged 5 commits into from
Jul 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rewrite metadata-dep-info to rmake
  • Loading branch information
Oneirical committed Jun 28, 2024
commit db21af1a72926571427dd62b51bb1757e88ae64b
1 change: 0 additions & 1 deletion src/tools/tidy/src/allowed_run_make_makefiles.txt
Original file line number Diff line number Diff line change
@@ -98,7 +98,6 @@ run-make/lto-smoke-c/Makefile
run-make/macos-deployment-target/Makefile
run-make/macos-fat-archive/Makefile
run-make/manual-link/Makefile
run-make/metadata-dep-info/Makefile
run-make/min-global-align/Makefile
run-make/mingw-export-call-convention/Makefile
run-make/mismatching-target-triples/Makefile
7 changes: 0 additions & 7 deletions tests/run-make/metadata-dep-info/Makefile

This file was deleted.

20 changes: 20 additions & 0 deletions tests/run-make/metadata-dep-info/rmake.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Emitting dep-info alongside metadata would present subtle discrepancies
// in the output file, such as the filename transforming underscores_ into hyphens-.
// After the fix in #114750, this test checks that the emitted files are identical
// to the expected output.
// See https://github.com/rust-lang/rust/issues/68839

use run_make_support::{diff, rustc};

fn main() {
rustc()
.emit("metadata,dep-info")
.crate_type("lib")
.input("dash-separated.rs")
.extra_filename("_something-extra")
.run();
diff()
.expected_file("dash-separated_something-extra.expected.d")
.actual_file("dash-separated_something-extra.d")
.run();
}