Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change assert_unsafe_precondition docs to refer to check_language_ub #129376

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Change assert_unsafe_precondition docs to refer to check_language_ub #129376

merged 1 commit into from
Aug 22, 2024

Conversation

ChaiTRex
Copy link
Contributor

@ChaiTRex ChaiTRex commented Aug 21, 2024 •
edited
Loading

Unstable feature ub_checks tracking issue #123499.

@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 21, 2024
@workingjubilee
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 21, 2024

📌 Commit dd76868 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2024
@the8472
Copy link
Member

the8472 commented Aug 21, 2024

That tracking issue is for the compiler feature. The feature I added to the library is only meant for internal use so std can use the core feature. It was not intended to be stabilized as a library feature.

@ChaiTRex
Copy link
Contributor Author

@the8472 Should I change it back to "none"? If so, will force pushing to my branch stop the merge?

@workingjubilee
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 21, 2024
@ChaiTRex ChaiTRex force-pushed the assert_unsafe_precondition_check_language_ub branch from dd76868 to c836739 Compare August 21, 2024 21:37
@ChaiTRex ChaiTRex changed the title Fix docs and tracking issue number for ub_checks Change assert_unsafe_precondition docs to refer to check_language_ub Aug 21, 2024
@ChaiTRex
Copy link
Contributor Author

@the8472 OK, I've removed the changes away from the tracking issue being "none".

@the8472
Copy link
Member

the8472 commented Aug 21, 2024 •
edited
Loading

Yeah my understanding of the compiler processes is that an MCP is not enough to stabilize those flags and it would require an RFC. So the corresponding libs feature also currently is not on a path to stabilitzation and will remain internal-only so it doesn't require a tracking issue.
And even if the compiler feature were stabilized exposing an API for that would be a separate discussion.

@ChaiTRex
Copy link
Contributor Author

OK, now the pull request only changes check_{library,lang}_ub to check_{library,language}_ub to match the rest of the documentation and the function name.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 21, 2024
@the8472
Copy link
Member

the8472 commented Aug 21, 2024

@bors r=workingjubilee,the8472

@bors
Copy link
Contributor

bors commented Aug 21, 2024

📌 Commit c836739 has been approved by workingjubilee,the8472

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 22, 2024
@jieyouxu
Rollup merge of rust-lang#129376 - ChaiTRex:assert_unsafe_preconditio…
738014a 
…n_check_language_ub, r=workingjubilee,the8472

Change `assert_unsafe_precondition` docs to refer to `check_language_ub`
@jieyouxu jieyouxu mentioned this pull request Aug 22, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 22, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 22, 2024
@bors
Auto merge of rust-lang#129398 - matthiaskrgr:rollup-50l01ry, r=matth…
8269be1 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128432 (WASI: forbid `unsafe_op_in_unsafe_fn` for `std::{os, sys}`)
 - rust-lang#129373 (Add missing module flags for CFI and KCFI sanitizers)
 - rust-lang#129374 (Use `assert_unsafe_precondition!` in `AsciiChar::digit_unchecked`)
 - rust-lang#129376 (Change `assert_unsafe_precondition` docs to refer to `check_language_ub`)
 - rust-lang#129382 (Add `const_cell_into_inner` to `OnceCell`)
 - rust-lang#129387 (Advise against removing the remaining Python scripts from `tests/run-make`)
 - rust-lang#129388 (Do not rely on names to find lifetimes.)
 - rust-lang#129395 (Pretty-print own args of existential projections (dyn-Trait w/ GAT constraints))

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ae58bbf into rust-lang:master Aug 22, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 22, 2024
@rust-timer
Unrolled build for rust-lang#129376
f787d5e 
Rollup merge of rust-lang#129376 - ChaiTRex:assert_unsafe_precondition_check_language_ub, r=workingjubilee,the8472

Change `assert_unsafe_precondition` docs to refer to `check_language_ub`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ChaiTRex @rustbot @workingjubilee @bors @the8472