Arbitrary self types: diagnostics for mismatched self types #129968
Closed
+94
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@rustbot label +S-waiting-on-author -S-waiting-on-review |
rustbot
added
S-waiting-on-author
adetaylor
force-pushed
the
arbitrary-self-types-fix-generic-diagnostics
branch
from
3c0de63 to
424067a
Compare
|
r? @wesleywiser (but not ready for review yet) |
adetaylor
force-pushed
the
arbitrary-self-types-fix-generic-diagnostics
branch
from
424067a to
deb750a
Compare
This comment has been minimized.
This comment has been minimized.
adetaylor
force-pushed
the
arbitrary-self-types-fix-generic-diagnostics
branch
from
deb750a to
f13ebc7
Compare
adetaylor
changed the title
adetaylor
force-pushed
the
arbitrary-self-types-fix-generic-diagnostics
branch
from
23db43a to
0c993f8
Compare
16 tasks
|
☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm going to close this because I'll consider doing it was part of step 8 of the overall plan here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra diagnostics for cases where self types don't match.
Most of this is new tests. These are slightly duplicative of the existing
arbitrary-self-from-method-substs.rstest, but test more permutations so it seems worth adding to the coverage as we explore improving the diagnostics here.Improved diagnostics were suggested in commit 05c5caa
This is a part of the arbitrary self types v2 project, rust-lang/rfcs#3519
and specifically the sub-issue exploring questions around generics,
#129147
Tracking:
arbitrary_self_types#44874