Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed wast version was released, remove randomization exemption #132295

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fixed wast version was released, remove randomization exemption #132295

merged 1 commit into from
Feb 27, 2025
+2 −3

Conversation

the8472
Copy link
Member

@the8472 the8472 commented Oct 28, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 28, 2024
@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 29, 2024

📌 Commit 673867e has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 29, 2024
@matthiaskrgr
Rollup merge of rust-lang#132295 - the8472:remove-randomize-exclusion…
94ee84f 
…1, r=onur-ozkan

fixed wast version was released, remove randomization exemption
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 29, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Oct 29, 2024
@workingjubilee
Rollup merge of rust-lang#132295 - the8472:remove-randomize-exclusion…
0f99a7e 
…1, r=onur-ozkan

fixed wast version was released, remove randomization exemption
@workingjubilee workingjubilee mentioned this pull request Oct 29, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2024
@bors
Auto merge of rust-lang#132307 - matthiaskrgr:rollup-xm136gd, r=matth…
7229824 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#130259 (Lower AST node id only once)
 - rust-lang#131441 (Add a new trait `proc_macro::ToTokens`)
 - rust-lang#132247 (stable_mir: Directly use types from rustc_abi)
 - rust-lang#132249 (compiler: Add rustc_abi dependence to the compiler)
 - rust-lang#132255 (Add `LayoutData::is_uninhabited` and use it)
 - rust-lang#132258 ([rustdoc] Unify variant struct fields margins with struct fields)
 - rust-lang#132260 (cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`)
 - rust-lang#132261 (refactor: cleaner check to return None)
 - rust-lang#132271 (Updating Fuchsia platform-support documentation)
 - rust-lang#132295 (fixed wast version was released, remove randomization exemption)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu
Copy link
Member

Failed in rollup #132307 (comment)

error[E0080]: evaluation of constant value failed
    --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/wast-219.0.0/src/core/expr.rs:1214:5
     |
1214 |     assert!(size <= pointer * 11);
     |     |
     |     |
     |     the evaluated program panicked at 'assertion failed: size <= pointer * 11', /cargo/registry/src/index.crates.io-6f17d22bba15001f/wast-219.0.0/src/core/expr.rs:1214:5
     |
    ::: /checkout/library/core/src/macros/mod.rs:1616:5

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Oct 29, 2024 •
edited
Loading

Probably wast needs more fixing 😅

@the8472 the8472 added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 3, 2024
@the8472 the8472 force-pushed the remove-randomize-exclusion1 branch from 673867e to 756013f Compare February 13, 2025 20:07
@the8472
Copy link
Member Author

the8472 commented Feb 26, 2025

wast has had additional fixes since then and Cargo.lock contains those updates, so let's try again

@bors r=onur-ozkan rollup=iffy

@bors
Copy link
Contributor

bors commented Feb 26, 2025

📌 Commit 756013f has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Feb 26, 2025
@bors
Copy link
Contributor

bors commented Feb 27, 2025

⌛ Testing commit 756013f with merge 96cfc75...

@bors
Copy link
Contributor

bors commented Feb 27, 2025

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 96cfc75 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 27, 2025
@bors bors merged commit 96cfc75 into rust-lang:master Feb 27, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 27, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (96cfc75): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.0% [2.0%, 2.0%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.979s -> 770.531s (-0.06%)
Artifact size: 361.96 MiB -> 361.97 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan

Assignees

@onur-ozkan onur-ozkan

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@the8472 @rustbot @onur-ozkan @bors @jieyouxu @rust-timer