Do not suggest borrow that is already there in fully-qualified call #132469
Conversation
When encountering `&str::from("value")` do not suggest `&&str::from("value")`.
Fix rust-lang#132041.
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
| if let hir::Node::Expr(expr) = self.tcx.parent_hir_node(*hir_id) | ||
| && let hir::ExprKind::Call(base, _) = expr.kind | ||
| && let hir::ExprKind::Path(hir::QPath::TypeRelative(ty, _)) = base.kind | ||
| && ty.span == span |
There was a problem hiding this comment.
I'm not following the logic: where in this condition are you checking that the expression is already borrowed?
There was a problem hiding this comment.
I can add the check for the existing borrow one level up, but I also wanted to avoid suggesting &str::from("") when we have str::from("") as that won't help either.
There was a problem hiding this comment.
I see, so the comment below could be saying something like "don't suggest borrowing when this wouldn't fix the problem (because the type is specified by a path instead of inferred)"?
There was a problem hiding this comment.
Ah I understand my confusion: I had understood "Do not suggest borrowing when we already do so" as "Do not suggest borrowing when the expression is already borrowed"
There was a problem hiding this comment.
Coming back to this: I still don't understand what this branch is catching. Can you rephrase the comment to be more explicit about what the branch means plz?
When encountering
&str::from("value")do not suggest&&str::from("value").Fix #132041.