Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtree sync for rustc_codegen_cranelift #132807

Merged
merged 21 commits into from
Nov 9, 2024

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 9, 2024

Apart from a perf optimization for some crates (rust-lang/rustc_codegen_cranelift#1541) not much changed this time as the last sync was less than a week ago.

r? @ghost

@rustbot label +A-codegen +A-cranelift +T-compiler

madsmtm and others added 21 commits November 1, 2024 17:07
The OS version depends on the deployment target environment variables,
the access of which we want to move to later in the compilation pipeline
that has access to more information, for example `env_depinfo`.
This changes the naming to the new naming, used by `--print
target-tuple`.
It does not change all locations, but many.
…orn3

Subtree sync for rustc_codegen_cranelift

The highlight this time is an update to Cranelift 0.113,

r? `@ghost`

`@rustbot` label +A-codegen +A-cranelift +T-compiler
This reverts commit 521288e.

I got what it tests backwards. It tests against a sysroot compiled with
LLVM. Not with the LLVM backend. The latter is done by the test_llvm CI
job.
For the coercions rustc-perf benchmark without this commit reduces the
total amount of time it takes to emit the object file from 270ms to
27ms.
Use a BufWriter in emit_module to reduce syscall overhead
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

@rustbot rustbot added A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend labels Nov 9, 2024
@bjorn3
Copy link
Member Author

bjorn3 commented Nov 9, 2024

@bors r+ p=1 subtree sync

@bors
Copy link
Contributor

bors commented Nov 9, 2024

📌 Commit c94f759 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2024
@bors
Copy link
Contributor

bors commented Nov 9, 2024

⌛ Testing commit c94f759 with merge b73478b...

@bors
Copy link
Contributor

bors commented Nov 9, 2024

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing b73478b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2024
@bors bors merged commit b73478b into rust-lang:master Nov 9, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 9, 2024
@bjorn3 bjorn3 deleted the sync_cg_clif-2024-11-09 branch November 9, 2024 17:22
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b73478b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.1%, secondary 4.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
4.4% [4.4%, 4.4%] 1
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.1% [-2.4%, 2.2%] 2

Cycles

Results (primary -3.8%, secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.8% [-4.0%, -3.5%] 2
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) -3.8% [-4.0%, -3.5%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 781.672s -> 781.253s (-0.05%)
Artifact size: 335.35 MiB -> 335.38 MiB (0.01%)

mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
…orn3

Subtree sync for rustc_codegen_cranelift

Apart from a perf optimization for some crates (rust-lang/rustc_codegen_cranelift#1541) not much changed this time as the last sync was less than a week ago.

r? `@ghost`

`@rustbot` label +A-codegen +A-cranelift +T-compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend has-merge-commits PR has merge commits, merge with caution. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants