Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable full debuginfo-level=2 in windows alt job #133246

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Nov 20, 2024

#132010 increased the time of the dist-x86_64-msvc-alt job by 1 hour.
As discussed on Zulip, we want to set this flag on linux only.

try-job: dist-x86_64-msvc-alt

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 20, 2024
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
…le, r=<try>

ci: Disable full `debuginfo-level=2` in windows alt job

try-job: dist-x86_64-msvc-alt
@bors
Copy link
Collaborator

bors commented Nov 20, 2024

⌛ Trying commit 91be815 with merge 113cffc...

@bors
Copy link
Collaborator

bors commented Nov 20, 2024

☀️ Try build successful - checks-actions
Build commit: 113cffc (113cffc0066a51b75e73fbc8aaac1061b4e026aa)

@marcoieni
Copy link
Member Author

The job took 2h 4m 🥳

@marcoieni marcoieni marked this pull request as ready for review November 20, 2024 15:26
@Kobzol
Copy link
Contributor

Kobzol commented Nov 20, 2024

Thanks for investigating!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 20, 2024

📌 Commit 91be815 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 21, 2024
…able, r=Kobzol

ci: Disable full `debuginfo-level=2` in windows alt job

try-job: dist-x86_64-msvc-alt
@matthiaskrgr
Copy link
Member

@bors rollup=never infra ci change

@jieyouxu jieyouxu added the A-CI Area: Our Github Actions CI label Nov 21, 2024
@bors
Copy link
Collaborator

bors commented Nov 21, 2024

⌛ Testing commit 91be815 with merge b19329a...

@bors
Copy link
Collaborator

bors commented Nov 21, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing b19329a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 21, 2024
@bors bors merged commit b19329a into rust-lang:master Nov 21, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 21, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b19329a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.9% [2.9%, 2.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.9% [2.9%, 2.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 796.819s -> 797.142s (0.04%)
Artifact size: 336.01 MiB -> 336.05 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants