Advent of `tests/ui` (misc cleanups and improvements) [1/N] #133900

jieyouxu · 2024-12-05T08:58:34Z

Part of #133895.

Misc improvements to some ui tests immediately under tests/ui/.

Best reviewed commit-by-commit.

Thanks @clubby789 for PR title suggestion 😸.

r? compiler

tests/ui/as-precedence.rs

jieyouxu · 2024-12-05T09:03:37Z

tests/ui/diagnostic-flags/allow-non-lint-warnings.rs

+//! This test tries to exercise that by checking that the "empty trait list for derive" warning for
+//! `#[derive()]` is permitted by `-A warnings`, which is a non-lint warning.


Remark: I elaborated on the "how" here because it was very not obvious how this test did the check.

jieyouxu · 2024-12-05T09:04:20Z

tests/ui/codegen/alias-uninit-value.rs

Discussion: this one I have no idea. I suspect this test in the current form is not checking what the original commit intended to check. git archaeology also failed me because in d7d3871 this test

started working correctly at some point.

and was unmarked as xfail (compile-fail at thew time).

Original form as in fb76c25 is:

tag sty { ty_nil; } type raw_t = rec(sty struct, option::t[str] cname, uint hash); fn mk_raw_ty(sty st, &option::t[str] cname) -> raw_t { ret rec(struct=st, cname=cname, hash=0u); } fn main() { mk_raw_ty(ty_nil, none[str]); }

Ah yes, tricky.

fmease

Thanks for your patience. r=me with concerns resolved and renaming-commits squashed into the respective previous commit.

tests/ui/alias-uninit-value.rs

fmease · 2024-12-09T19:31:44Z

tests/ui/codegen/alias-uninit-value.rs

Ah yes, tricky.

tests/ui/allow-non-lint-warnings.rs

tests/ui/artificial-block.rs

fmease · 2024-12-09T21:13:00Z

tests/ui/as-precedence.rs

Lol, interesting corner case of the language. I never thought about operator precedence in code like &() as &Trait + Send: It gets parsed as &() as &(Trait) + Send instead of &() as &(Trait + Send) and therefore Send doesn't get interpreted as a trait object trait bound.

jieyouxu · 2024-12-10T03:11:38Z

Rebase force-push, no functional changes, intended to make review easier.

jieyouxu · 2024-12-10T03:15:28Z

Squash force-push, no functional changes, squashed move commits into the test content changes for each test.

- Document and tidy up `alias-uninit-value.rs` - Move `alias-uninit-value.rs` to `tests/ui/codegen/`

- Document `allow-non-lint-warnings.rs` - Move `allow-non-lint-warnings.rs` under `tests/ui/diagnostic-flags/` - Improve the test to use two *differential* revisions: 1. One revision checks that without `-A warnings` the code sample actually emits a warning. 2. The other revision checks that `-A warnings` suppresses the warning. This makes sure that if the code sample no longer warns, the test doesn't silently pass but fail to check its intended purpose.

- Document `anonymous-higher-ranked-lifetime.rs` - Move `anonymous-higher-ranked-lifetime.rs` to `tests/ui/higher-ranked`

- Document `artificial-block.rs` - Move `artificial-block.rs` under `tests/ui/reachable`

- Document `as-precedence.rs` - Move `as-precedence.rs` under `tests/ui/parser/`

jieyouxu · 2024-12-10T03:41:19Z

Changes since last review

Diff: https://github.com/rust-lang/rust/compare/32b9336c54b0f2b42ca37f1132979cee3c0030b5..56efa0a7bf55aa4d1413008df672b95f09a4d8e9

tests/ui/codegen/alias-uninit-value.rs: fixed non camel case types to remove distraction.
tests/ui/diagnostic-flags/allow-non-lint-warnings.rs:
1. Changed the test to use a code sample that actually emits a non-lint warning.
2. Make the test use differential revisions: one revision checks that without -A warnings the code sample does actually emit a warning, and another revision checks that the warning is suppressed if -A warnings cli flag is specified. This makes sure that the code sample under test doesn't silently pass yet fail to check that non-lint warnings can be suppressed by -A warnings if the code sample no longer emits any non-lint warnings to be suppressed.
tests/ui/reachable/artificial-block.rs:
1. Fix comment code snippet to use modern syntax.
2. Fix the incorrect commit hash 8d38182 when I actually meant 3d738e9.
3. Various typo/rewording.

Commits are squashed and rebased before force-push 56efa0a to help with the compare diff, they contain no changes beforehand.

@rustbot ready

fmease

Beautiful, thanks a lot!

differential revisions

🙏 🙏 🙏

fmease · 2024-12-13T07:04:40Z

@bors r+ rollup

bors · 2024-12-13T07:04:43Z

📌 Commit 56efa0a has been approved by fmease

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133900 (Advent of `tests/ui` (misc cleanups and improvements) [1/N]) - rust-lang#133937 (Keep track of parse errors in `mod`s and don't emit resolve errors for paths involving them) - rust-lang#133938 (`rustc_mir_dataflow` cleanups, including some renamings) - rust-lang#134058 (interpret: reduce usage of TypingEnv::fully_monomorphized) - rust-lang#134130 (Stop using driver queries in the public API) - rust-lang#134140 (Add AST support for unsafe binders) - rust-lang#134229 (Fix typos in docs on provenance) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#133900 - jieyouxu:ui-cleanup-1, r=fmease Advent of `tests/ui` (misc cleanups and improvements) [1/N] Part of rust-lang#133895. Misc improvements to some ui tests immediately under `tests/ui/`. Best reviewed commit-by-commit. Thanks `@clubby789` for PR title suggestion 😸. r? compiler

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133900 (Advent of `tests/ui` (misc cleanups and improvements) [1/N]) - rust-lang#133937 (Keep track of parse errors in `mod`s and don't emit resolve errors for paths involving them) - rust-lang#133938 (`rustc_mir_dataflow` cleanups, including some renamings) - rust-lang#134058 (interpret: reduce usage of TypingEnv::fully_monomorphized) - rust-lang#134130 (Stop using driver queries in the public API) - rust-lang#134140 (Add AST support for unsafe binders) - rust-lang#134229 (Fix typos in docs on provenance) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu added the A-testsuite label Dec 5, 2024

rustbot assigned fmease Dec 5, 2024

rustbot added S-waiting-on-review T-compiler labels Dec 5, 2024

jieyouxu commented Dec 5, 2024

View reviewed changes

tests/ui/as-precedence.rs Outdated Show resolved Hide resolved

jieyouxu mentioned this pull request Dec 5, 2024

Tracking Issue for ui test suite improvements #133895

Open

jieyouxu commented Dec 5, 2024

View reviewed changes

jieyouxu added the C-cleanup label Dec 5, 2024

This comment was marked as outdated.

Sign in to view

rustbot assigned wesleywiser and unassigned fmease Dec 7, 2024

fmease assigned fmease and unassigned wesleywiser Dec 7, 2024

jieyouxu changed the title ~~Daily ui test suite cleanups and improvements [1/N]~~ Advent of tests/ui (misc cleanups and improvements) [1/N] Dec 8, 2024

jieyouxu force-pushed the ui-cleanup-1 branch from b7ae207 to b797dc2 Compare December 8, 2024 14:24

fmease approved these changes Dec 9, 2024

View reviewed changes

fmease added S-waiting-on-author and removed S-waiting-on-review labels Dec 9, 2024

jieyouxu force-pushed the ui-cleanup-1 branch from b797dc2 to 0e8f602 Compare December 10, 2024 03:11

jieyouxu force-pushed the ui-cleanup-1 branch from 0e8f602 to 32b9336 Compare December 10, 2024 03:14

jieyouxu and others added 5 commits December 10, 2024 11:20

Adjust alias-uninit-value.rs

dd3b313

- Document and tidy up `alias-uninit-value.rs` - Move `alias-uninit-value.rs` to `tests/ui/codegen/`

Adjust anonymous-higher-ranked-lifetime.rs

d734d22

- Document `anonymous-higher-ranked-lifetime.rs` - Move `anonymous-higher-ranked-lifetime.rs` to `tests/ui/higher-ranked`

Adjust artificial-block.rs

4652b14

- Document `artificial-block.rs` - Move `artificial-block.rs` under `tests/ui/reachable`

Adjust as-precedence.rs

56efa0a

- Document `as-precedence.rs` - Move `as-precedence.rs` under `tests/ui/parser/`

jieyouxu force-pushed the ui-cleanup-1 branch from 32b9336 to 56efa0a Compare December 10, 2024 03:34

rustbot added S-waiting-on-review and removed S-waiting-on-author labels Dec 10, 2024

jieyouxu requested a review from fmease December 10, 2024 03:48

fmease approved these changes Dec 13, 2024

View reviewed changes

bors added S-waiting-on-bors and removed S-waiting-on-review labels Dec 13, 2024

matthiaskrgr mentioned this pull request Dec 13, 2024

Rollup of 7 pull requests #134269

Merged

bors merged commit ab0d792 into rust-lang:master Dec 14, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Dec 14, 2024

jieyouxu deleted the ui-cleanup-1 branch December 14, 2024 04:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Advent of `tests/ui` (misc cleanups and improvements) [1/N] #133900

Advent of `tests/ui` (misc cleanups and improvements) [1/N] #133900

jieyouxu commented Dec 5, 2024 •

edited

Loading

jieyouxu Dec 5, 2024

jieyouxu Dec 5, 2024 •

edited

Loading

jieyouxu Dec 5, 2024

fmease Dec 9, 2024

This comment was marked as outdated.

fmease left a comment

fmease Dec 9, 2024

fmease Dec 9, 2024 •

edited

Loading

jieyouxu commented Dec 10, 2024 •

edited

Loading

jieyouxu commented Dec 10, 2024

jieyouxu commented Dec 10, 2024 •

edited

Loading

fmease left a comment •

edited

Loading

fmease commented Dec 13, 2024

bors commented Dec 13, 2024

		//! This test tries to exercise that by checking that the "empty trait list for derive" warning for
		//! `#[derive()]` is permitted by `-A warnings`, which is a non-lint warning.

Advent of tests/ui (misc cleanups and improvements) [1/N] #133900

Advent of tests/ui (misc cleanups and improvements) [1/N] #133900

Conversation

jieyouxu commented Dec 5, 2024 • edited Loading

jieyouxu Dec 5, 2024

Choose a reason for hiding this comment

jieyouxu Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

jieyouxu Dec 5, 2024

Choose a reason for hiding this comment

fmease Dec 9, 2024

Choose a reason for hiding this comment

This comment was marked as outdated.

fmease left a comment

Choose a reason for hiding this comment

fmease Dec 9, 2024

Choose a reason for hiding this comment

fmease Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

jieyouxu commented Dec 10, 2024 • edited Loading

jieyouxu commented Dec 10, 2024

jieyouxu commented Dec 10, 2024 • edited Loading

Changes since last review

fmease left a comment • edited Loading

Choose a reason for hiding this comment

fmease commented Dec 13, 2024

bors commented Dec 13, 2024

Advent of `tests/ui` (misc cleanups and improvements) [1/N] #133900

Advent of `tests/ui` (misc cleanups and improvements) [1/N] #133900

jieyouxu commented Dec 5, 2024 •

edited

Loading

jieyouxu Dec 5, 2024 •

edited

Loading

fmease Dec 9, 2024 •

edited

Loading

jieyouxu commented Dec 10, 2024 •

edited

Loading

jieyouxu commented Dec 10, 2024 •

edited

Loading

fmease left a comment •

edited

Loading