Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize the cell_update feature #134446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize the cell_update feature #134446

wants to merge 1 commit into from
+1 −5

Conversation

tgross35
Copy link
Contributor

FCP finished in June at #50186 (comment) but a PR never got made. Stabilize the feature here.

Closes: #50186

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2024

The Miri subtree was changed

cc @rust-lang/miri

@tgross35
Copy link
Contributor Author

There was some continued discussion on the thread after FCP started. I don't think anything changed, but I'll request libs-api take a look to double check.

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 18, 2024
@rustbot rustbot assigned m-ou-se and unassigned workingjubilee Dec 18, 2024
@tgross35 tgross35 removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Dec 18, 2024
@GrigorenkoPV
Copy link
Contributor

Should we maybe change the signature from

    pub fn update<F>(&self, f: F) -> T
    where
        F: FnOnce(T) -> T,

to

    pub fn update(&self, f: impl FnOnce(T) -> T) -> T

analogous to #135956?

@bors
Copy link
Contributor

bors commented Jan 27, 2025

☔ The latest upstream changes (presumably #135937) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35
Copy link
Contributor Author

tgross35 commented Mar 6, 2025

Nominating for libs-api to:

  1. Double check that the ~10 messages on the tracking issue since FCP started don't change any feelings about this API. The main discussion point is name and return value (old or new)
  2. Consider the signature change proposed above

@rustbot label +I-libs-api-nominated

@rustbot rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Mar 6, 2025
@m-ou-se m-ou-se added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for Cell::update
6 participants
@tgross35 @rustbot @GrigorenkoPV @bors @m-ou-se @workingjubilee