Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macro_metavar_expr_concat] Add support for nested repetitions #135102

Closed
wants to merge 1 commit into from
Closed

[macro_metavar_expr_concat] Add support for nested repetitions #135102

wants to merge 1 commit into from
+170 −22

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Jan 4, 2025 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 4, 2025

r? compiler

@rustbot rustbot assigned BoxyUwU and unassigned jieyouxu Jan 4, 2025
@c410-f3r
Copy link
Contributor Author

c410-f3r commented Jan 7, 2025 •
edited
Loading

r? compiler

@rustbot rustbot assigned estebank and Nadrieril and unassigned BoxyUwU and estebank Jan 7, 2025
@Nadrieril
Copy link
Member

Sounds like your domain r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned Nadrieril Jan 13, 2025
@c410-f3r
Copy link
Contributor Author

At least I tried but it seems that it is going to be you again, @petrochenkov

Looks like you are on vacation so there is no rush

@Nadrieril Nadrieril mentioned this pull request Jan 14, 2025
Closed
@c410-f3r c410-f3r closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro metavar expr concat doesn't work with nested repetitions
7 participants
@c410-f3r @rustbot @jieyouxu @Nadrieril @estebank @petrochenkov @BoxyUwU