Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Zharden-sls flag (target modifier) added to enable mitigation against straight line speculation (SLS) #136597

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

azhogin
Copy link
Contributor

@azhogin azhogin commented Feb 5, 2025

Flag (target modifier) to mitigate against straight line speculation (SLS).
-Zharden-sls=[none|all|return|indirect-jmp].

The flag enables the related features: +harden-sls-ijmp,+harden-sls-ret.
The flag is tracked as a target modifier to be equal between linked crates.

@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2025

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2025
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@klensy
Copy link
Contributor

klensy commented Feb 25, 2025

First commit adds retpoline feature, but PR descriptions says about sls.

@azhogin azhogin marked this pull request as draft February 25, 2025 18:23
@azhogin
Copy link
Contributor Author

azhogin commented Feb 25, 2025

First commit adds retpoline feature, but PR descriptions says about sls.

Yes, first commit is in another PR #135927.
This one depends on.

@Dylan-DPC
Copy link
Member

Marking this as blocked on #135927

@Dylan-DPC Dylan-DPC added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants