Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Fuchsia target spec with clang Fuchsia driver #136892

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Sync Fuchsia target spec with clang Fuchsia driver #136892

merged 1 commit into from
Mar 14, 2025
+45 −22

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Feb 12, 2025 •
edited
Loading

This updates the Fuchsia target spec with the Clang Fuchsia driver, which picks up a few changes:

  • Adds -z start-stop-visibility=hidden and -z rel to the pre link arguments.
  • Adds --execute-only and --fix-cortex-a53-843419 for aarch64-unknown-fuchsia.
  • Enables the equivalent cpu features for x86-64-v2 for x86_64-unknown-fuchsia, which is our minimum supported x86_64 platform according to RFC-0073.

try-job: x86_64-fuchsia

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@erickt erickt marked this pull request as draft February 12, 2025 00:06
@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2025
@erickt erickt force-pushed the fuchsia-target branch 5 times, most recently from f937e74 to 57cbfa8 Compare February 12, 2025 19:50
@bors
Copy link
Contributor

bors commented Feb 17, 2025

☔ The latest upstream changes (presumably #136953) made this pull request unmergeable. Please resolve the merge conflicts.

@erickt erickt requested a review from petrhosek February 18, 2025 22:53
@erickt erickt marked this pull request as ready for review February 20, 2025 01:31
@erickt
Copy link
Contributor Author

erickt commented Feb 20, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 20, 2025
@bors
Auto merge of rust-lang#136892 - erickt:fuchsia-target, r=<try>
dcce89f 
Sync Fuchsia target spec with clang Fuchsia driver

This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes:

* Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments.
* Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`.
* Enables the equivalent cpu features for `x86-64-v2` for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64 platform according to [RFC-0073].

try-job: x86_64-fuchsia

[Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp
[RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement
@bors
Copy link
Contributor

bors commented Feb 20, 2025

⌛ Trying commit ee372d8 with merge dcce89f...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Feb 20, 2025

💔 Test failed - checks-actions

@erickt
Sync Fuchsia target spec with clang Fuchsia driver
746b0f6 
This updates the Fuchsia target spec with the [Clang Fuchsia driver],
which picks up a few changes:

* Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link
  arguments.
* Adds `--execute-only` and `--fix-cortex-a53-843419` for
  `aarch64-unknown-fuchsia`.
* Enables the cpu features equivalent to x86-64-v2 for
  `x86_64-unknown-fuchsia`, which is our minimum supported x86_64.
  platform according to [RFC-0073].
* Enables the cpu features `+crc,+aes,+sha2,+neon` on aarch64.
* Increases the max atomic width on 86_64 to 128.
* Enables stack probes and xray on aarch64 and riscv64.

[Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp
[RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement
@erickt
Copy link
Contributor Author

erickt commented Feb 20, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 20, 2025
@bors
Auto merge of rust-lang#136892 - erickt:fuchsia-target, r=<try>
b46ed62 
Sync Fuchsia target spec with clang Fuchsia driver

This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes:

* Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments.
* Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`.
* Enables the equivalent cpu features for `x86-64-v2` for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64 platform according to [RFC-0073].

try-job: x86_64-fuchsia

[Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp
[RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement
@bors
Copy link
Contributor

bors commented Feb 20, 2025

⌛ Trying commit 746b0f6 with merge b46ed62...

@bors
Copy link
Contributor

bors commented Feb 20, 2025

☀️ Try build successful - checks-actions
Build commit: b46ed62 (b46ed6219967cf6e46cf381c68fb7d323a2299cc)

@jieyouxu
Copy link
Member

Hi @erickt, is this ready for review?

@erickt
Copy link
Contributor Author

erickt commented Mar 10, 2025

@jieyouxu - I'll get back to you later on today, we just got fuchsia compiling again with some of the new lints that recently got turned on, so I'm doing a dry run to make sure this patch doesn't cause any problems.

@jieyouxu
Copy link
Member

No rush, just asking in case it was waiting on review but I wasn't looking at it.

@erickt
Copy link
Contributor Author

erickt commented Mar 13, 2025

@jieyouxu this tested fine on our side, so it should be ready to land. Thanks!

@jieyouxu jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2025
jieyouxu
jieyouxu approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes look reasonable to me as well.

@jieyouxu jieyouxu added the O-fuchsia Operating system: Fuchsia label Mar 14, 2025
@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 14, 2025

📌 Commit 746b0f6 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@jhpratt jhpratt mentioned this pull request Mar 14, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
@bors
Auto merge of rust-lang#138480 - jhpratt:rollup-y3b8wu5, r=jhpratt
f7b4354 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#136001 (Overhaul examples for PermissionsExt)
 - rust-lang#136230 (Reword incorrect documentation about SocketAddr having varying layout)
 - rust-lang#136892 (Sync Fuchsia target spec with clang Fuchsia driver)
 - rust-lang#136911 (Add documentation URL to selected jobs)
 - rust-lang#137870 ( Improve HashMap docs for const and static initializers)
 - rust-lang#138179 (Add `src/tools/x` to the main workspace)
 - rust-lang#138389 (use `expect` instead of `allow`)
 - rust-lang#138396 (Enable metrics and verbose tests in PR CI)
 - rust-lang#138398 (atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance)
 - rust-lang#138432 (fix: remove the check of lld not supporting `@response-file)`
 - rust-lang#138434 (Visit `PatField` when collecting lint levels)
 - rust-lang#138441 (update error message)
 - rust-lang#138442 (EUV: fix place of deref pattern's interior's scrutinee)
 - rust-lang#138457 (Remove usage of legacy scheme paths on RedoxOS)
 - rust-lang#138461 (Remove an outdated line from a test comment)
 - rust-lang#138466 (Remove myself from libs review)

Failed merges:

 - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 459352a into rust-lang:master Mar 14, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 14, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
@rust-timer
Unrolled build for rust-lang#136892
49fa43f 
Rollup merge of rust-lang#136892 - erickt:fuchsia-target, r=jieyouxu

Sync Fuchsia target spec with clang Fuchsia driver

This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes:

* Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments.
* Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`.
* Enables the equivalent cpu features for `x86-64-v2` for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64 platform according to [RFC-0073].

try-job: x86_64-fuchsia

[Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp
[RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement
@erickt erickt deleted the fuchsia-target branch March 19, 2025 04:11
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 19, 2025
@bors
Auto merge of rust-lang#138480 - jhpratt:rollup-y3b8wu5, r=jhpratt
0b766fc 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#136001 (Overhaul examples for PermissionsExt)
 - rust-lang#136230 (Reword incorrect documentation about SocketAddr having varying layout)
 - rust-lang#136892 (Sync Fuchsia target spec with clang Fuchsia driver)
 - rust-lang#136911 (Add documentation URL to selected jobs)
 - rust-lang#137870 ( Improve HashMap docs for const and static initializers)
 - rust-lang#138179 (Add `src/tools/x` to the main workspace)
 - rust-lang#138389 (use `expect` instead of `allow`)
 - rust-lang#138396 (Enable metrics and verbose tests in PR CI)
 - rust-lang#138398 (atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance)
 - rust-lang#138432 (fix: remove the check of lld not supporting `@response-file)`
 - rust-lang#138434 (Visit `PatField` when collecting lint levels)
 - rust-lang#138441 (update error message)
 - rust-lang#138442 (EUV: fix place of deref pattern's interior's scrutinee)
 - rust-lang#138457 (Remove usage of legacy scheme paths on RedoxOS)
 - rust-lang#138461 (Remove an outdated line from a test comment)
 - rust-lang#138466 (Remove myself from libs review)

Failed merges:

 - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e

@petrhosek petrhosek

@jieyouxu jieyouxu

Assignees

@jieyouxu jieyouxu

Labels
O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@erickt @rustbot @bors @rust-log-analyzer @jieyouxu @petrhosek @taiki-e