Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skip_whitespace do a single pass #137027

Closed
wants to merge 1 commit into from

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Feb 14, 2025

Offshoot from #136931 that I'd like to see the performance impact of.

r? @nnethercote

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Feb 14, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
Make skip_whitespace do a single pass

Offshoot from rust-lang#136931 that I'd like to see the performance impact of.

r? `@nnethercote`
@bors
Copy link
Contributor

bors commented Feb 14, 2025

⌛ Trying commit d15cd2e with merge a13e5e9...

@bors
Copy link
Contributor

bors commented Feb 14, 2025

☀️ Try build successful - checks-actions
Build commit: a13e5e9 (a13e5e9a6871141d69bd9fd1bcd399e546e5a835)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a13e5e9): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 790.438s -> 788.744s (-0.21%)
Artifact size: 347.75 MiB -> 347.73 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
…try>

Make skip_whitespace do a single pass (with bytes)

Probably better alternative to rust-lang#137027.

r? `@nnethercote`
@hkBst
Copy link
Member Author

hkBst commented Feb 20, 2025

Closing this in favor of #137275

@hkBst hkBst closed this Feb 20, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 20, 2025
…try>

Make skip_whitespace do a single pass (with bytes)

Probably better alternative to rust-lang#137027.

r? `@nnethercote`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants