-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize flags for doctest cross compilation #137096
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
ab9d4c8
to
a676b04
Compare
This PR modifies cc @jieyouxu The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
a676b04
to
8aaa90b
Compare
☔ The latest upstream changes (presumably #138830) made this pull request unmergeable. Please resolve the merge conflicts. |
This renames `--runtool` and `--runtool-arg` to `--test-runtool` and `--test-runtool-arg` to maintain consistency with other `--test-*` arguments.
8aaa90b
to
a0799de
Compare
This removes the `--enable-per-target-ignores` and enables it unconditionally.
a0799de
to
ddc6525
Compare
@fmease @GuillaumeGomez Just checking if this can be put on the team's radar? |
On my review list now. :) |
I think they've been around for enough time. Let's start an FCP then. @rfcbot fcp merge |
Team member @GuillaumeGomez has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
This makes the following changes in preparation for supporting doctest cross-compiling in cargo:
--runtool
and--runtool-arg
to--test-runtool
and--test-runtool-arg
to maintain consistency with other--test-*
arguments.--test-runtool
and--test-runtool-arg
. These are needed in order to support cargo'starget.runner
option which specifies a runner to execute a cross-compiled doctest (for example, qemu).--enable-per-target-ignores
flag by removing it and making it unconditionally enabled. This makes it possible to disable a doctest on a per-target basis, which I think will be helpful for rolling out this feature.These changes were suggested in https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/stabilizing.20doctest.20xcompile/near/409281127
The intent is to stabilize the doctest-xcompile feature in cargo. This will help ensure that for projects that do cross-compile testing that their doctests are also covered. Currently there is a somewhat surprising behavior that they are ignored.
Closes #64245